mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

Added missing function definition in SecPeiCpuExceptionMu

Open kenlautner opened this issue 1 year ago • 1 comments

Description

Added ExceptionPersistanceLib and SecPeiCpuExceptionMu. The following commits are included here:

98c1649 f54f81f3 b7ad337

The following are descriptions around these commits:

Added ExceptionPersistenceLib for early boot exceptions.


Added SecPeiCpuExceptionMu as a new CpuException library implementation.


Added missing function definition in SecPeiCpuExceptionMu that was added upstream but not included in our SecPeiCpuException implementation.


  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

Was able to successfully use the new SecPeiCpuExceptionMu library to record early exceptions.

Integration Instructions

N/A.

kenlautner avatar Jun 26 '24 04:06 kenlautner

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@4fd6116). Learn more about missing BASE report.

Files Patch % Lines
...rsistenceLibNull/BaseExceptionPersistenceLibNull.c 0.00% 37 Missing :warning:
...ibrary/CpuExceptionHandlerLib/SecPeiCpuException.c 0.00% 6 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #961   +/-   ##
=================================================
  Coverage                  ?    0.78%           
=================================================
  Files                     ?      932           
  Lines                     ?   314459           
  Branches                  ?     3625           
=================================================
  Hits                      ?     2455           
  Misses                    ?   311662           
  Partials                  ?      342           
Flag Coverage Δ
MdeModulePkg 0.60% <0.00%> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 2.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 27 '24 02:06 codecov-commenter