mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

Update GenFvInternalLib.c to no longer require file and section alignment for DXE

Open spbrogan opened this issue 1 year ago • 1 comments

temp change to resolve this issue

Description

<Please include a description of the change and why this change was made.>

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

N/A

spbrogan avatar May 04 '24 00:05 spbrogan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.01%. Comparing base (95ffdfe) to head (9fb51a9). Report is 16 commits behind head on release/202302.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202302     #840   +/-   ##
===============================================
  Coverage            1.01%    1.01%           
===============================================
  Files                1278     1278           
  Lines              325549   325549           
  Branches             4792     4792           
===============================================
  Hits                 3316     3316           
  Misses             322194   322194           
  Partials               39       39           
Flag Coverage Δ
MdeModulePkg ∅ <ø> (∅)
MdePkg ∅ <ø> (∅)
NetworkPkg ∅ <ø> (∅)
PolicyServicePkg ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 04 '24 00:05 codecov-commenter

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 16 '24 23:07 github-actions[bot]

Abandoning this PR as we went a different direction here.

os-d avatar Jul 17 '24 17:07 os-d