mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

Declare mock SMM Access2 Protocol.

Open ishih1 opened this issue 1 year ago • 9 comments

Description

Declare mock SMM Access2 Protocol for google test.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • [ ] Impacts functionality?
  • [ ] Impacts security?
  • [ ] Breaking change?
  • [ ] Includes tests?
  • [ ] Includes documentation?

How This Was Tested

Run the google test.

Integration Instructions

N/A

ishih1 avatar Oct 08 '24 05:10 ishih1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.59%. Comparing base (fcba1de) to head (7493a83).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1177   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362501   362501           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356618   356618           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 08 '24 06:10 codecov-commenter

@ishih1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{lenovo}"]

ishih1 avatar Oct 08 '24 06:10 ishih1

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Lenovo"

ishih1 avatar Oct 08 '24 06:10 ishih1

@VivianNK Please review this PR, thanks.

ishih1 avatar Oct 15 '24 08:10 ishih1

@VivianNK Please review this PR, thanks.

@ishih1 Hi, please create a PR to edk2 (https://github.com/tianocore/edk2) with this change

VivianNK avatar Oct 15 '24 19:10 VivianNK

@VivianNK Please review this PR, thanks.

@ishih1 Hi, please create a PR to edk2 (https://github.com/tianocore/edk2) with this change

The PR has already been created. https://github.com/tianocore/edk2/pull/6299

ishih1 avatar Oct 16 '24 01:10 ishih1

@VivianNK Please approve the PR if there is no more comment.

ishih1 avatar Oct 17 '24 01:10 ishih1

@VivianNK Please help to merge this PR. Thanks.

ishih1 avatar Oct 21 '24 01:10 ishih1

@VivianNK Please check the update.

ishih1 avatar Oct 24 '24 02:10 ishih1