mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

Add Line Ending plugin

Open kenlautner opened this issue 1 year ago • 3 comments

Description

Cherry-pick the LineEndingCheck plugin in its entirety as well as update all line endings to be CRLF to pass the new pipeline check.

The commits included from 202311: 8080124b16 6ddc3a56ea 59f33826b1 24a4f428e8 418f07b5b8

These commits do the following:

Revert the temporary commit disabling the ARM and ARM64 pipeline builds for CI and Basetools. This ensures that all normal Mu CI is run after this point.

Fixed a bug where the plugin would fail if not run from the projects root directory.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

  • [ ] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

N/A

kenlautner avatar Sep 21 '24 02:09 kenlautner

⚠️ Please add a meaningful PR title (remove the 'Personal/' prefix from the title).

github-actions[bot] avatar Sep 21 '24 02:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.59%. Comparing base (f65edd8) to head (f4d22ee).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1150   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362501   362501           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356618   356618           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 21 '24 02:09 codecov-commenter

Please update the PR title and description to be more descriptive and accurate to the changes.

makubacki avatar Sep 23 '24 15:09 makubacki