mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

TCBZ2596: Added FltUsedLib to MdePkg

Open kenlautner opened this issue 1 year ago • 1 comments

Description

This library provides a global (fltused) that needs to be defined anywhere floating point operations are used. The C compiler produces the _fltused symbol by default, this is just to satisfy the linker.

  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

Tested in Qemu.

Integration Instructions

This information is included in the Readme.md file. To use FltUsedLib, just include it in the INF of the module that uses floating point.

[LibraryClasses]
  BaseLib
  BaseMemoryLib
  FltUsedLib

kenlautner avatar Jun 28 '24 20:06 kenlautner

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@378ba56). Learn more about missing BASE report.

Files Patch % Lines
MdePkg/Library/FltUsedLib/FltUsedLib.c 0.00% 1 Missing :warning:
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202405   #1012   +/-   ##
================================================
  Coverage                  ?   5.41%           
================================================
  Files                     ?     495           
  Lines                     ?   43004           
  Branches                  ?    1722           
================================================
  Hits                      ?    2330           
  Misses                    ?   40655           
  Partials                  ?      19           
Flag Coverage Δ
MdePkg 5.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 28 '24 21:06 codecov-commenter