mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

Changed gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport default value to FALSE

Open kenlautner opened this issue 1 year ago • 1 comments

Description

Changed gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport default value to FALSE. This will prevent potential runtime type memory bucket size fluctuation in release builds.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [x] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

If a platform was depending on PcdHiiOsRuntimeSupport being TRUE they'll need to update the value in their platform dsc file.

kenlautner avatar Jun 28 '24 20:06 kenlautner

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release/202405@ca023ee). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405    #1007   +/-   ##
=================================================
  Coverage                  ?    0.68%           
=================================================
  Files                     ?      929           
  Lines                     ?   315608           
  Branches                  ?     2666           
=================================================
  Hits                      ?     2165           
  Misses                    ?   313401           
  Partials                  ?       42           
Flag Coverage Δ
MdeModulePkg 0.24% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 28 '24 20:06 codecov-commenter