live-share icon indicating copy to clipboard operation
live-share copied to clipboard

GHPRI support

Open bamurtaugh opened this issue 2 years ago • 1 comments

Using the GHPRI extension with Live Share would enable very powerful workflows. But, there are a few issues in using them together:

  • No GHPRI view when in a Live Share session, so can't review the PR together
  • No GHPRI diff views
    • Focusing on a regular file as a host opened a split tab for the guest
  • GHPRI comments option in dropdown should capitalize A (@alexr00 I think this would be a change on the GHPRI side?) image
  • Can't make comments together with GHRPI
    • Desired scenario: review things together; guest reviews hosts PR or vice versa
    • Experience today: Can't make comments in guest's PR. End up opening the PR separately

cc @derekbekoe @alexr00 @isidorn @fubaduba

bamurtaugh avatar Dec 01 '22 22:12 bamurtaugh

@bamurtaugh that string ("add ActionWidgetService Live Share Session Comments") appears to be coming from Live Share.

alexr00 avatar Dec 02 '22 14:12 alexr00