live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Consider to use the vscode accessibility setting instead of introducing new ones

Open isidorn opened this issue 3 years ago • 1 comments
trafficstars

VS Code PM here 👋

I like the great work you did to make LiveShare accessible using custom sounds 👏 I also noticed that you have introduced a custom setting for this. To simplify I suggest to just use the vscode editor.accessibilitySupport setting instead. And if that one is turned on you can automatically play sounds.

So the dev change would be that your setting also supports a value "auto" which is the new default, which means if vs code accessibility mode is on just play sounds. And then users can opt out of this by changing that setting.

This way blind users will not have to find your setting, everything would just work.

All the best

isidorn avatar May 12 '22 13:05 isidorn

Great suggestion. We'll take it!

daytonellwanger avatar May 12 '22 17:05 daytonellwanger

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically in 2 days.

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

Please do not auto close it :)

isidorn avatar Aug 15 '22 10:08 isidorn

@isidorn: Thanks for the suggestion! This change is included in the latest release: 1.0.5788

jramsay avatar Dec 05 '22 20:12 jramsay

@jramsay thanks a lot 👏

isidorn avatar Dec 06 '22 10:12 isidorn