fluentui
fluentui copied to clipboard
microsoft
Update usePortalMountNodeStyles.styles.ts
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: cfacaff0d52a2d226b2ac4935f35d6608089cd01 (build)
![size-auditor[bot] avatar](https://avatars.githubusercontent.com/in/13711?v=4 "Published by a pub.dev verified publisher"){kind=small}
Perf Analysis (@fluentui/react-components)
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 74 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 578 | 571 | 5000 | |
| Button | mount | 309 | 298 | 5000 | |
| Field | mount | 1008 | 1024 | 5000 | |
| FluentProvider | mount | 639 | 648 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 74 | 10 | Possible regression |
| InfoButton | mount | 10 | 19 | 5000 | |
| MakeStyles | mount | 879 | 876 | 50000 | |
| Persona | mount | 1621 | 1607 | 5000 | |
| SpinButton | mount | 1229 | 1279 | 5000 |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit d43676a9c69a62c20c11999c05aaf841b04da5cd:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
| compassionate-drake-xfzvv9 | Issue #26579 |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊 Bundle size report
| Package & Exports | Baseline (minified/GZIP) | PR | Change |
|---|---|---|---|
| react-combobox Combobox (including child components) |
87.771 kB28.249 kB |
87.915 kB28.321 kB |
144 B 72 B |
| react-combobox Dropdown (including child components) |
86.11 kB27.854 kB |
86.254 kB27.93 kB |
144 B 76 B |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
211.151 kB58.715 kB |
211.295 kB58.801 kB |
144 B 86 B |
| react-datepicker-compat DatePicker Compat |
222.624 kB59.214 kB |
222.768 kB59.29 kB |
144 B 76 B |
| react-infobutton InfoButton |
132.502 kB40.405 kB |
132.646 kB40.467 kB |
144 B 62 B |
| react-infobutton InfoLabel |
135.967 kB41.466 kB |
136.111 kB41.528 kB |
144 B 62 B |
| react-menu Menu (including children components) |
133.229 kB40.538 kB |
133.373 kB40.617 kB |
144 B 79 B |
| react-menu Menu (including selectable components) |
136.213 kB41.069 kB |
136.357 kB41.146 kB |
144 B 77 B |
| react-popover Popover |
119.464 kB36.745 kB |
119.608 kB36.799 kB |
144 B 54 B |
| react-portal Portal |
11.676 kB4.31 kB |
11.82 kB4.391 kB |
144 B 81 B |
| react-tooltip Tooltip |
47.119 kB16.528 kB |
47.263 kB16.585 kB |
144 B 57 B |
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| react-alert Alert |
93.624 kB22.563 kB |
| react-avatar Avatar |
57.872 kB15.115 kB |
| react-avatar AvatarGroup |
15.682 kB6.306 kB |
| react-avatar AvatarGroupItem |
74.048 kB19.605 kB |
| react-components react-components: Button, FluentProvider & webLightTheme |
64.935 kB17.918 kB |
| react-components react-components: FluentProvider & webLightTheme |
36.168 kB11.964 kB |
| react-dialog Dialog (including children components) |
92.16 kB27.502 kB |
| react-overflow hooks only |
11.206 kB4.266 kB |
| react-persona Persona |
64.793 kB17.036 kB |
| react-portal-compat PortalCompatProvider |
6.473 kB2.196 kB |
| react-table DataGrid |
150.941 kB41.535 kB |
| react-table Table (Primitives only) |
45.147 kB12.577 kB |
| react-table Table as DataGrid |
133.392 kB34.008 kB |
| react-table Table (Selection only) |
79.161 kB19.386 kB |
| react-table Table (Sort only) |
78.491 kB19.195 kB |
| react-tags Tag |
22.04 kB7.94 kB |
@microsoft/cxe-coastal can you please review this PR? (changes in tests)
I'm currently getting a scroll jump back to the top of the page when I open a positioned element that gets focus when opened -- the "Trapping Focus" Popover example shows this for me (on all browsers on both macOS and Windows, regardless of opening with mouse or keyboard). Looks like it's related to removing the
position: fixedthing.
Thanks for reporting @smhigley 👍 ~~I will check what is the difference to existing examples in VR tests and why it's not captured by them.~~
Edit: I fixed the problem (reverted changes to applying styles) and created a new VR test.
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links: