fluentui
fluentui copied to clipboard
microsoft
fix: TableHeaderCell should not render button when not sortable
Using the approach with the smallest impact to API and slot rendering.
Previous Behavior
The slot rendered a native button always, but with role="presentation" when it was not interactive.
New Behavior
The slot always renders a div but with ARIA button semantics when it is interactive
Related Issue(s)
Fixes #27633
Asset size changes
Size Auditor did not detect a change in bundle size for any component!
Baseline commit: 1a277b9c4d55bc1b7c65a73383425b1934ec1dad (build)
![size-auditor[bot] avatar](https://avatars.githubusercontent.com/in/13711?v=4 "Published by a pub.dev verified publisher"){kind=small}
Perf Analysis (@fluentui/react-components)
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 65 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 597 | 582 | 5000 | |
| Button | mount | 297 | 296 | 5000 | |
| Field | mount | 1036 | 1034 | 5000 | |
| FluentProvider | mount | 684 | 656 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 59 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 65 | 10 | Possible regression |
| InfoButton | mount | 9 | 11 | 5000 | |
| MakeStyles | mount | 859 | 831 | 50000 | |
| Persona | mount | 1674 | 1595 | 5000 | |
| SpinButton | mount | 1265 | 1323 | 5000 |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit ffc1fd115febf68480f10526dfc6f64702d8b556:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊 Bundle size report
| Package & Exports | Baseline (minified/GZIP) | PR | Change |
|---|---|---|---|
| react-table DataGrid |
156.269 kB42.766 kB |
156.306 kB42.785 kB |
37 B 19 B |
| react-table Table (Primitives only) |
44.615 kB12.472 kB |
44.652 kB12.468 kB |
37 B -4 B |
| react-table Table as DataGrid |
131.923 kB33.783 kB |
131.96 kB33.791 kB |
37 B 8 B |
| react-table Table (Selection only) |
77.524 kB19.166 kB |
77.561 kB19.178 kB |
37 B 12 B |
| react-table Table (Sort only) |
76.854 kB18.976 kB |
76.891 kB18.989 kB |
37 B 13 B |
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| react-components react-components: Button, FluentProvider & webLightTheme |
65.162 kB17.952 kB |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
210.365 kB58.697 kB |
| react-components react-components: FluentProvider & webLightTheme |
36.395 kB11.996 kB |
| react-portal-compat PortalCompatProvider |
6.473 kB2.196 kB |
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/[email protected] has been released which incorporates this pull request.:tada:
Handy links: