fast icon indicating copy to clipboard operation
fast copied to clipboard

Refactor `fast-colors` to support tsconfig with `noImplicitAny`, `strictNullChecks` and `strictPropertyInitialization`

Open chrisdholt opened this issue 4 years ago • 2 comments

As part of #5303 we turned off @typescript-eslint/typedef globally as it was overwritten across multiple packages. As part of that, we turned on noImplicitAny, strictNullChecks, strictPropertyInitialization for all packages. Turning this on revealed several issues related to both tsconfig settings in fast-colors and so it was turned off explicitly for that package. The errors should be fixed and addressed as part of this issue and the code should be tested to ensure that there are no breaks or side effects of the change. This issue exists to track turning that back on and resolving the errors.

chrisdholt avatar Oct 29 '21 00:10 chrisdholt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 18:04 stale[bot]

Hey @chrisdholt! Is this issue still valid. I would like to contribute to this project, and would like to know the first few steps to resolve this issue.

imrishabh18 avatar Sep 04 '22 12:09 imrishabh18

The @microsoft/fast-colors package has been removed and deprecated.

janechu avatar May 29 '24 02:05 janechu