cpp_client_telemetry icon indicating copy to clipboard operation
cpp_client_telemetry copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

CI pipeline failure

Open natalieparry opened this issue 3 years ago • 2 comments
trafficstars

The CI pipeline for C/C++ on Windows (defined here) reports success even when several builds fail. See this example where I recently broke the win32-dll build but the pipeline reported success (search "(Rebuild target(s)) -- FAILED" to easily find the issues). It also appears common for the sqllite build to be broken (as seen in this PR which did not introduce a bug the way mine did).

natalieparry avatar Jan 05 '22 18:01 natalieparry

Thanks for reporting it. Seems this line https://github.com/microsoft/cpp_client_telemetry/blob/c5e79bfd3aed528a07cfa87e608a33693d767b62/.github/workflows/build-windows-vs2019.yaml#L26 is preventing failure to be flagged. It was added as part of #768. Tagging @maxgolov if he still remember why this was done :)

lalitb avatar Jan 06 '22 01:01 lalitb

Ok my bad, Seems the above change is only to prevent submodules checkout failures to be flagged, need to investigate more here.

lalitb avatar Jan 06 '22 16:01 lalitb