codeql-container icon indicating copy to clipboard operation
codeql-container copied to clipboard

Use `--build-arg` to specify versions during the build process

Open RA80533 opened this issue 4 years ago • 1 comments

  • https://github.com/microsoft/codeql-container/blob/d0e531a4b7db837e7e92e8d611b1226eb45ef861/Dockerfile#L58
  • https://github.com/microsoft/codeql-container/blob/d0e531a4b7db837e7e92e8d611b1226eb45ef861/Dockerfile#L65-L66
  • https://github.com/microsoft/codeql-container/blob/d0e531a4b7db837e7e92e8d611b1226eb45ef861/Dockerfile#L67-L68
  • https://github.com/microsoft/codeql-container/blob/d0e531a4b7db837e7e92e8d611b1226eb45ef861/Dockerfile#L70-L73

These occurrences can be updated to vastly improve the idempotence of building the Docker image. Right now, running docker build produces different images based on when the command is run. It could change quite a bit over the course of a week.

RA80533 avatar May 24 '21 03:05 RA80533

Good point. I'll put this in the backlog, alternatively, I'll be happy to accept a pull request.

jacobmsft avatar Nov 21 '21 15:11 jacobmsft