calculator
calculator copied to clipboard
microsoft
Fix C++ warnings
Fixes
- Rewrote operations to align more literally with the function's intentions
- Clarify what happens in support.cpp
It's not every day you discover MSVC is the one with a compilation bug, considering it is why only one test failed due to a refactoring despite other compilers generating identical code
https://godbolt.org/z/6Mqz75jvM
A link to what I think about the warning fixes: https://github.com/microsoft/STL/pull/3079#issuecomment-1238585115
A lot of these changes are modernizations. Every single refactoring has been thoroughly tested and there is no behavioral change outside of some functions being changed to an equivalent form.
Can you please stop rebasing and pushing? Microsoft usually do squash merging anyway so your rebases are moot.
Thanks for all the work you've put into this PR! Unfortunately, this change is too big for us to review. The feedback you received in the microsoft/STL repo (https://github.com/microsoft/STL/pull/3079#issuecomment-1238796896) is good advice here in microsoft/calculator too. We would be happy to take many of these changes, but please break them into smaller PRs with good descriptions.
Also consider forgetting how to rebase and force push as it's only ever needed ONLY if you accidentally push credentials onto github like API tokens (to quickly remove them) but then again, they will instantly become invalidated if they are github ones.
That should be the ONLY reason to force push, other than for merge conflicts (unless Microsoft says otherwise which they keep telling you to not do it).