botframework-sdk icon indicating copy to clipboard operation
botframework-sdk copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Fixed Swagger spec

Open ItalyPaleAle opened this issue 4 years ago • 1 comments

In the Swagger spec, the operationId Conversations_GetConversationMembers was defined twice, and that caused an issue with the Swagger CLI's validation. One of the two instances should have been Conversations_GetConversationMember instead.

ItalyPaleAle avatar Apr 06 '21 02:04 ItalyPaleAle

I made a second commit that also added:

  • "x-nullable": true to all date fields
  • "x-omitempty": true to all arrays

When generating a client with go-swagger, these options are required to ensure that zero dates or empty arrays are not included in the resulting JSON.

Not only including them would be a mistake, but they actually crash the Bot Framework Emulator app.

ItalyPaleAle avatar Apr 14 '21 04:04 ItalyPaleAle