botframework-sdk icon indicating copy to clipboard operation
botframework-sdk copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Action.execute (AC 1.4) support

Open clearab opened this issue 4 years ago • 8 comments

Add support for the Action.Execute command and various flows, including the action/execute invoke and auth flows in both the activity handler and adaptive triggers.

OBI spec is here: https://github.com/microsoft/botframework-obi/pull/128

Hacked up webchat that can do AC 1.4 cards: https://github.com/clearab/CateringDemo

Tracking Status

Dotnet SDK Issue

  • [x] PR
  • [x] Merged

Javascript SDK Issue

  • [X] PR
  • [X] Merged

Python SDK Issue

  • [X] PR
  • [x] Merged

Java SDK Issue

  • [x] PR
  • [x] Merged

**Docs

  • [x] PR
  • [x] Merged

clearab avatar Feb 03 '21 20:02 clearab

Existing documentation (based on the JSON payloads) https://docs.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/universal-actions-for-adaptive-cards/overview?tabs=mobile

clearab avatar Jun 04 '21 17:06 clearab

@JonathanFingold We're merged in all SDKs for this one. Do you need to do anything with Docs for this?

mdrichardson avatar Jun 15 '21 15:06 mdrichardson

@mdrichardson @clearab - I'll need a recommended approach to building bots that support this feature, and actionable messages in particular, for both SDK-first bots and Composer bots. (Adding @kaerm )

  • On the SDK side, it would seems like an activity handler bot without dialogs would make sense, at least for less complicated bots.
  • On the Composer side, I'm guessing custom middleware or a custom channel/connection would make sense, but would not be easy.

JonathanFingold avatar Jun 15 '21 16:06 JonathanFingold

PS. Will the protocol doc get copied to the botframework-sdk repo and be public?

JonathanFingold avatar Jun 15 '21 16:06 JonathanFingold

I'm going to create some work items for creating (porting really) a sample, as well as documenting. Its in a bit of an odd space, as lots of our partners are documenting this for channel-specific implementations.

clearab avatar Jun 15 '21 16:06 clearab

I'll leave this open though, and associate those new items back.

clearab avatar Jun 15 '21 16:06 clearab

~~@clearab I just noticed that none of the merged PRs for this add triggers for Adaptive, at least as far as I can tell. I came into this one after just about everything was already merged--can you verify that:~~

~~1) We want adaptive triggers for this, and~~ ~~2) If we do, we don't already have them~~

~~I feel like this issue is much bigger than I originally understood (adaptive triggers, auth) and could use a second set of eyes to verify where this one is actually at~~

mdrichardson avatar Jun 17 '21 22:06 mdrichardson

@clearab Disregard last. I found it in Components/AdaptiveCards

mdrichardson avatar Jun 18 '21 16:06 mdrichardson