botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

[PORT] Fix WaterfallStepContext to use parent dc properly

Open tomlm opened this issue 5 years ago • 4 comments

Port this change from botbuilder-dotnet/master branch: https://github.com/microsoft/botbuilder-dotnet/pull/3855

fixes #3854

  • cleaned up CreateInnerDC so it is applied consistently
  • changed WaterfallStepContext ctor to pass in parent dc.

Changed projects

  • Microsoft.Bot.Builder.Dialogs

tomlm avatar May 02 '20 17:05 tomlm

might be relevant. Needs checking.

cleemullins avatar May 04 '20 18:05 cleemullins

@tracyboehrer this would involve porting all the bi-directional traversing of dialogs (child and parent), is this something we want to do in R10?

axelsrz avatar Jun 23 '20 19:06 axelsrz

@axelsrz Do we have the resources for it? Otherwise, it is marked investigate, so we could limit it to recording what needs to be done.

tracyboehrer avatar Jun 23 '20 20:06 tracyboehrer

Note: part of the dotnet PR is being rolled back. see: https://github.com/microsoft/botbuilder-dotnet/pull/4480

EricDahlvang avatar Aug 19 '20 21:08 EricDahlvang