azuredatastudio
azuredatastudio copied to clipboard
microsoft
Copy entire build output before publish
Address #25517
Recent change in DacFx removed full paths of references from build output. Because ADS copies the dacpac to a temp location before publish (due to a locking issue #11036), this is causing the referenced dacpac to not be found. Fix is to copy the entire output folder which should contain all the necessary references.
Pull Request Test Coverage Report for Build 10586167192
Details
- 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
- 4 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.005%) to 41.72%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| extensions/sql-database-projects/src/controllers/projectController.ts | 5 | 8 | 62.5% |
| <!-- | Total: | 5 | 8 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| extensions/sql-database-projects/src/common/httpClient.ts | 1 | 66.18% |
| extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts | 1 | 45.22% |
| extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts | 2 | 52.03% |
| <!-- | Total: | 4 |
| Totals | |
|---|---|
| Change from base Build 10572064744: | -0.005% |
| Covered Lines: | 30727 |
| Relevant Lines: | 68921 |
💛 - Coveralls
@zijchen is this change still planned or should this be closed as abandoned?
@zijchen is this change still planned or should this be closed as abandoned?
We decided to revert the change in DacFx which was why I left this PR idle, but I think it's still good to have because there could be other artifacts the dacpac requires and expects in the same folder. I'll merge it.