autogen
autogen copied to clipboard
Fix _last_msg_as_summary for LMM
Why are these changes needed?
The content could be either a string a list.
Related issue number
@afourney
Checks
- [ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
- [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
- [X] I've made sure all auto checks have passed.
Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
4a44093) to head (f0d49dc). Report is 2188 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| autogen/agentchat/conversable_agent.py | 0.00% | 9 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
- Coverage 38.14% 0.00% -38.15%
==========================================
Files 78 81 +3
Lines 7865 8108 +243
Branches 1683 1753 +70
==========================================
- Hits 3000 0 -3000
- Misses 4615 8108 +3493
+ Partials 250 0 -250
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 0.00% <0.00%> (-38.14%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Are there other LMM contributors or users that can be added as reviewers?
@WaelKarkoub Please take a look at this PR, which is related to the carryover in your #2124 PR.
@jackgerrits Do you see any issues regarding the function in this PR?
Hmm I don't have my head fully around the ramifications. Does this mean that agents can return a list now as the response and this is to be interpreted as the list of user/text content parts? Ultimately, we going to want to give that some more structure, but for now this seems like an okay step
@jackgerrits
Yes, UserProxy might give a list (text and image) to the assistant agent. Group chat manager might give a list (text and image) to the members in the group. Etc.
Moreover, in the future, Dalle and Sora can return a list as response, which contains images/videos/text etc.
Could you add a test to cover the new code?
Could you add a test to cover the new code?
@BeibinLi this is a friendly reminder in case you missed the comment.
@BeibinLi The revision looks good. Could you add a test? Thank you!
@qingyun-wu @sonichi Test case with chat_res_play_with_multimodal added. Since the function is private, we should not explicitly test it by design. So, I added a block of code inside test_summary.
The notification system of GitHub is a little bit confusing. I often miss important messages from PRs and Issues...
@qingyun-wu @sonichi Let me know if the test case is sufficient.
Could you fix the conflicts?