agent-lightning
agent-lightning copied to clipboard
New example: Google ADK
New Example: ADK Agent
Adds a new example demonstrating ADK agent training with Agent-Lightning. ADK is an observability framework for agent traces with span visualization and Cloud Trace integration.
Files Added:
examples/google_adk/adk_agent.py- LitAdkAgent implementationexamples/google_adk/train_adk.py- Training script with CI supportexamples/google_adk/adk_debug.py- Sanity check scriptexamples/google_adk/prepare_dataset.py- Dataset conversion utilitydocs/how-to/train-adk-agent.md- Comprehensive training guide- Updated
pyproject.tomlwithadkoptional dependency group
@microsoft-github-policy-service agree [company="KellySit"]
@microsoft-github-policy-service agree
@ultmaster Thank you so much for the feedback. I have made some updates based on the feedback:
- Fixed unnecessary changes (examples/apo/room_selector_apo.py)
- Updated adk_agent.py and adk_debug.py
- Added training result showcase to docs/how-to/train-adk-agent.md
- Added CI and renewed prepare_dataset.py
- Omitted unnecessary things (docs/how-to/train-adk-agent.md, examples/google_adk/README.md)
The changes are now pushed and ready for re-review. The latest commit is the ready one. Thanks.
@KellySit Great work but seems you have to resolve the conflict before the CI can run !
@ultmaster PTAL, conflicts resolved. Thank you!
Hi. Appreciate the improvements.
Given the implementation of current LitAdkAgent, I recommend using the style of @agl.rollout, which would be more concise. You only need to keep the async version. No need for both.
Another question is, would you mind changing a dataset? I don't want all the examples focusing on a single spider dataset. If you want to stick to spider, you can augment the existing how to train sql how-to document by adding a section about ADK; and merge the examples into spider directory. There is no need for another example directory --- which could cause confusion on why this is not called spider, do we prefer langchain over ADK, or whatever.
Also, would you allow me to edit the PR so that I can make some minor improvements and verify with CI?
Great example, I love you