agent-lightning icon indicating copy to clipboard operation
agent-lightning copied to clipboard

New example: Google ADK

Open KellySit opened this issue 3 weeks ago • 7 comments

New Example: ADK Agent

Adds a new example demonstrating ADK agent training with Agent-Lightning. ADK is an observability framework for agent traces with span visualization and Cloud Trace integration.

Files Added:

  • examples/google_adk/adk_agent.py - LitAdkAgent implementation
  • examples/google_adk/train_adk.py - Training script with CI support
  • examples/google_adk/adk_debug.py - Sanity check script
  • examples/google_adk/prepare_dataset.py - Dataset conversion utility
  • docs/how-to/train-adk-agent.md - Comprehensive training guide
  • Updated pyproject.toml with adk optional dependency group

KellySit avatar Nov 13 '25 15:11 KellySit

@microsoft-github-policy-service agree [company="KellySit"]

KellySit avatar Nov 13 '25 15:11 KellySit

@microsoft-github-policy-service agree

KellySit avatar Nov 13 '25 15:11 KellySit

@ultmaster Thank you so much for the feedback. I have made some updates based on the feedback:

  • Fixed unnecessary changes (examples/apo/room_selector_apo.py)
  • Updated adk_agent.py and adk_debug.py
  • Added training result showcase to docs/how-to/train-adk-agent.md
  • Added CI and renewed prepare_dataset.py
  • Omitted unnecessary things (docs/how-to/train-adk-agent.md, examples/google_adk/README.md)

The changes are now pushed and ready for re-review. The latest commit is the ready one. Thanks.

KellySit avatar Nov 19 '25 10:11 KellySit

@KellySit Great work but seems you have to resolve the conflict before the CI can run !

JasonHonKL avatar Nov 19 '25 17:11 JasonHonKL

@ultmaster PTAL, conflicts resolved. Thank you!

KellySit avatar Nov 19 '25 18:11 KellySit

Hi. Appreciate the improvements.

Given the implementation of current LitAdkAgent, I recommend using the style of @agl.rollout, which would be more concise. You only need to keep the async version. No need for both.

Another question is, would you mind changing a dataset? I don't want all the examples focusing on a single spider dataset. If you want to stick to spider, you can augment the existing how to train sql how-to document by adding a section about ADK; and merge the examples into spider directory. There is no need for another example directory --- which could cause confusion on why this is not called spider, do we prefer langchain over ADK, or whatever.

Also, would you allow me to edit the PR so that I can make some minor improvements and verify with CI?

ultmaster avatar Nov 20 '25 01:11 ultmaster

Great example, I love you

johnson7788 avatar Dec 04 '25 03:12 johnson7788