WinUI-Gallery
WinUI-Gallery copied to clipboard
microsoft
Rounded Corners Sample
Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?
- [x] New sample
- [ ] Addition to existing sample
- [ ] Modification to existing sample
If this is an addition/modification to an existing sample page, which one?
Describe the sample
Add a new sample that shows off:
- Rounded corners on a set of existing controls
- How to customize rounded corners
- How to turn off rounded corners if necessary
Consider adding a link to the Xaml Fluent Theme Editor which also supports these scenarios.
Is your sample request related to a problem? Please describe it
Additional context
@Chips1234 - fantastic! Please reach out if you have any questions 😁
CC: @chigy @kikisaints for FYI
Alright. Thanks. One problem is, how do I get rid of light-up when the textbox comes into focus? I put it into a border but the highlight is a problem (see picture)
Alright. Thanks. One problem is, how do I get rid of light-up when the textbox comes into focus? I put it into a border but the highlight is a problem (see picture)
@Chips1234 , could you tell me why you are trying to do that? We should just show rounding of the corner of the light-up and not start redesigning the control with this effort.
I’m trying to put it into a border as shown here. I tried CornerRadius within the text box but an error says that “CornerRadius” does not support older versions of Win10.
@Chips1234 , I wanted to share how we do work for WinUI in terms of how each sample apps and documents are connected and we use them to help developers/designers. I thought this is important for you to be aware as you investigate the work you would work on this proposal.
This proposal touches on 3 ways we communicate with our developer/designer audiences:
- Documentation - https://docs.microsoft.com/en-us/windows/uwp/design/style/rounded-corner
- We document the guidance, sample code, etc. so that developer and designer audiences know how to use them properly. For this effort, we'd like to make sure the sample you write in Controls Gallery match that of sample shared in this doc. If you require to write additional code, we want to make sure we consider updating the guidance.
- Controls Gallery - This is our "live" sharing of the controls and guidance.
- Idea is that we are releasing examples and samples that match what we talk about in the above documentation. We also take screenshots of the samples to use them in the documentation so we want to make sure samples produce quality examples.
- Theme Editor - This app let designer/developer to create a visual using the properties we expose to create types of UI customization that still ensure not deviating too much to require retemplating.
- Idea is that the type of sample code you wrote in Controls Gallery are things users of Theme Editor can see updated automatically.
Let me know if you have any questions about this.
@kikisaints , please take a look and comment on @Chips1234 comment here?
I’m trying to put it into a border as shown here. I tried CornerRadius within the text box but an error says that “CornerRadius” does not support older versions of Win10.
@stmoy So you want a separate page on corner radius or do you just want a new example in the existing pages (e.g. new example on the button page)?
Ok
From: Marcel Wagner [email protected] Sent: Wednesday, July 15, 2020 11:37:25 AM To: microsoft/Xaml-Controls-Gallery [email protected] Cc: Eric Tian [email protected]; Mention [email protected] Subject: Re: [microsoft/Xaml-Controls-Gallery] Rounded Corners Sample (#375)
I think a separate page would be the best for this,
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Xaml-Controls-Gallery/issues/375#issuecomment-658934329, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RSFOFE5JGPF5DOVLKDR3XZOLANCNFSM4LF4NTVA.
@chigy If I set CornerRadius, I get this: Warning, XLS1105, The property ‘CornerRadius’ on type ‘Button’ is not available in the target platform minimum version (10.0.17134.0) supported by this project. I can set a conditional namespace though, is that what you want me to do?
I think a separate page would be the best for this,
+1
I can set a conditional namespace though, is that what you want me to do?
Conditional Xaml would be the appropriate way to handle this, yes. In addition, please be sure to set the MinimumUniversalAPIContract on the ControlExample.
Ok
From: Steven Moyes [email protected] Sent: Thursday, July 16, 2020 1:09:56 PM To: microsoft/Xaml-Controls-Gallery [email protected] Cc: Eric Tian [email protected]; Mention [email protected] Subject: Re: [microsoft/Xaml-Controls-Gallery] Rounded Corners Sample (#375)
I think a separate page would be the best for this,
+1
I can set a conditional namespace though, is that what you want me to do?
Conditional Xaml would be the appropriate way to handle this, yes. In addition, please be sure to set the MinimumUniversalAPIContract on the ControlExample.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Xaml-Controls-Gallery/issues/375#issuecomment-659644279, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RSGX2K7XYPV7FYVXGLR35NBJANCNFSM4LF4NTVA.
a slider would be pretty cool!
btw is Fluent XAML Theme Editor (https://www.microsoft.com/store/productId/9N2XD3Q8X57C or https://github.com/microsoft/fluent-xaml-theme-editor) dead?
CC: @kikisaints for this:
btw is Fluent XAML Theme Editor (https://www.microsoft.com/store/productId/9N2XD3Q8X57C or https://github.com/microsoft/fluent-xaml-theme-editor) dead?
I believe the answer is "no, not dead - just not being actively invested in"
@jay-o-way I'm pretty sure this is still relevant given there exists no sample that I know of that showcases this.