TypeScript Pr issue 57087 - fix for relating (e.g. satisfies) function overloads to intersection specifications

Usage Scenario:

Suppose an intersection type:

interface C {
  (x:1):"1";
  (x:2):"20";
  (x:number):number | "1" | "20";
};
interface B {
  (x:2):"2"
  (x:3):"30"
  (x:number):number | "2" | "30";
};
interface A {
  (x:3):"3"
  (x:1):"10"
  (x:number):number | "3" | "10";
};

Current behavior

Without this pull, in order to write an implementation, the only reliable error-free overload implementation and declaration requires concatenating all the declarations of the intersection type as follows:

function foo2(x:1):"1";
function foo2(x:2):"20";
function foo2(x:number):number;
function foo2(x:2):"2"
function foo2(x:3):"30"
function foo2(x:number):number;
function foo2(x:3):"3"
function foo2(x:1):"10"
function foo2(x:number):number;
function foo2(x:number){
  if (x===1) return "1";
  if (x===2) return "2";
  if (x===3) return "3";
  // (*) These runtime-unused extra lines need to be added 
  // to make the implementation compatible with the overload signature
  if (x===1) return "10";
  if (x===2) return "20";
  if (x===3) return "30";
  return x;
}

That has disadvantages:

The large number of overloads in the declaration imposes a workload on the ts compiler downstream.
It is not user friendly.
The compiler also requires runtime-unused extra lines need to be added to make the implementation compatible with the overload signature.

New Behavior

With this pull the following declaration and implementation are allowed instead:

function foo1(x:1):"1";
function foo1(x:2):"2";
function foo1(x:3):"3";
function foo1(x:number):number;
function foo1(x:number){
  if (x===1) return "1";
  if (x===2) return "2";
  if (x===3) return "3";
  return x;
}

Implementation

Where

The function checkOverloadsRelatedToIntersection is called only when

(target.flags & TypeFlags.Intersection) and
typeRelatedToEachType(source,target) returned Ternary.False
the number of source signatures is >1.

Therefore, it only affect cases which were previously rejected.

Algorithm

Algorithm used within checkOverloadsRelatedToIntersection:

Let s[i], i in 0...Ns-1 be the source overloads.

Let t[j], j in 0...Nt-1 be the target intersection member types.

Let t[j][k], k in 0...Ntj-1 be the target overloads in type t[j].

SourceDomainMatch(i):==
    For some j,k exists IdentitiyRelation(Parameters<s[i]>,Parameters<t[j][k]>)===true

SourceRangeMatch(i):==
    Let rt be the union of ReturnTypes<t[j][k]> for all j,k s.t. Parameters<s[i]> assignable to Parameters<t[j][k]>
    ReturnTypes<s[i]> assignable to rt

TargetDomainMatch(t[j,k]):==
    For some i exists IdentitiyRelation(Parameters<s[i]>,Parameters<t[j][k]>)===true

Passing conditions:
- For all i, SourceDomainMatch(i)===true
- For all i, SourceRangeMatch(i)===true
- For all j,k, TargetDomainMatch(t[j][k])===true

SourceDomainMatch checks that source domain maps into the target domain. SourceRangeMatch checks that source range maps into the target range. TargetDomainMatch checks that target domain maps into the source domain

Diff URL

Fixes #57112

Feb 13 '24 09:02 craigphicks

The TypeScript team hasn't accepted the linked issue #57087. If you can get it accepted, this PR will have a better chance of being reviewed.

Feb 13 '24 09:02 typescript-bot

@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this @typescript-bot user test tsserver @typescript-bot test tsserver top100 @typescript-bot run dt @typescript-bot perf test this @typescript-bot pack this

Feb 22 '24 21:02 RyanCavanaugh

Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Update: The results are in!

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the regular perf test suite on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Update: The results are in!

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Update: The results are in!

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Update: The results are in!

Feb 22 '24 21:02 typescript-bot

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Feb 22 '24 21:02 typescript-bot

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159985/artifacts?artifactName=tgz&fileId=7AB40D8DBAA394D139B88F615EF71F015207AD8DB1D1B617E1361782B6C5F54C02&fileName=/typescript-5.5.0-insiders.20240222.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Feb 22 '24 21:02 typescript-bot

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/57395/merge:

Everything looks good!

Feb 22 '24 21:02 typescript-bot

@RyanCavanaugh The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,653k (± 0.01%)}	_{295,692k (± 0.01%)}	_{+39k (+ 0.01%)}	_295,674k	_295,728k	_{p=0.037 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.28%)}	_~	_2.65s	_2.67s	_{p=0.241 n=6}
_{Bind Time}	_{0.83s (± 1.08%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.550 n=6}
_{Check Time}	_{8.24s (± 0.30%)}	_{8.33s (± 0.21%)}	_{+0.09s (+ 1.07%)}	_8.30s	_8.35s	_{p=0.005 n=6}
_{Emit Time}	_{7.10s (± 0.43%)}	_{7.09s (± 0.25%)}	_~	_7.08s	_7.12s	_{p=0.935 n=6}
_{Total Time}	_{18.84s (± 0.15%)}	_{18.91s (± 0.13%)}	_{+0.08s (+ 0.41%)}	_18.87s	_18.93s	_{p=0.007 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,575k (± 1.69%)}	_{192,644k (± 1.27%)}	_~	_191,617k	_197,662k	_{p=0.810 n=6}
_{Parse Time}	_{1.36s (± 1.39%)}	_{1.36s (± 0.00%)}	_~	_1.36s	_1.36s	_{p=1.000 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.34%)}	_{9.49s (± 0.58%)}	_{+0.13s (+ 1.39%)}	_9.43s	_9.58s	_{p=0.005 n=6}
_{Emit Time}	_{2.62s (± 0.59%)}	_{2.62s (± 0.66%)}	_~	_2.59s	_2.64s	_{p=0.865 n=6}
_{Total Time}	_{14.06s (± 0.16%)}	_{14.19s (± 0.40%)}	_{+0.13s (+ 0.95%)}	_14.13s	_14.29s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,488k (± 0.00%)}	_{347,514k (± 0.01%)}	_~	_347,437k	_347,541k	_{p=0.066 n=6}
_{Parse Time}	_{2.48s (± 0.33%)}	_{2.48s (± 0.97%)}	_~	_2.44s	_2.51s	_{p=0.801 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.97s (± 0.23%)}	_{7.07s (± 0.40%)}	_{+0.09s (+ 1.36%)}	_7.02s	_7.10s	_{p=0.004 n=6}
_{Emit Time}	_{4.05s (± 0.36%)}	_{4.05s (± 0.60%)}	_~	_4.02s	_4.09s	_{p=0.871 n=6}
_{Total Time}	_{14.43s (± 0.16%)}	_{14.53s (± 0.41%)}	_{+0.10s (+ 0.70%)}	_14.44s	_14.59s	_{p=0.016 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,856k (± 0.01%)}	_{302,878k (± 0.01%)}	_{+22k (+ 0.01%)}	_302,850k	_302,897k	_{p=0.045 n=6}
_{Parse Time}	_{2.02s (± 0.99%)}	_{2.01s (± 0.51%)}	_~	_2.00s	_2.03s	_{p=0.459 n=6}
_{Bind Time}	_{1.00s (± 0.52%)}	_{1.00s (± 0.41%)}	_~	_0.99s	_1.00s	_{p=0.595 n=6}
_{Check Time}	_{6.36s (± 0.40%)}	_{6.40s (± 0.41%)}	_{+0.04s (+ 0.63%)}	_6.36s	_6.43s	_{p=0.044 n=6}
_{Emit Time}	_{3.58s (± 0.35%)}	_{3.57s (± 0.25%)}	_~	_3.56s	_3.58s	_{p=0.209 n=6}
_{Total Time}	_{12.96s (± 0.27%)}	_{12.98s (± 0.11%)}	_~	_12.96s	_13.00s	_{p=0.227 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,287k (± 0.00%)}	_{511,299k (± 0.00%)}	_~	_511,258k	_511,328k	_{p=0.423 n=6}
_{Parse Time}	_{2.65s (± 0.48%)}	_{2.65s (± 0.39%)}	_~	_2.64s	_2.67s	_{p=0.615 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=1.000 n=6}
_{Check Time}	_{17.29s (± 0.50%)}	_{17.42s (± 0.24%)}	_{+0.13s (+ 0.72%)}	_17.34s	_17.45s	_{p=0.019 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.38%)}	_{21.07s (± 0.17%)}	_{+0.14s (+ 0.65%)}	_21.01s	_21.10s	_{p=0.008 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,293,609k (± 0.00%)}	_{2,317,954k (± 0.00%)}	_{+24,345k (+ 1.06%)}	_2,317,919k	_2,317,979k	_{p=0.005 n=6}
_{Parse Time}	_{11.95s (± 0.87%)}	_{11.99s (± 1.00%)}	_~	_11.87s	_12.17s	_{p=0.810 n=6}
_{Bind Time}	_{2.63s (± 0.20%)}	_{2.64s (± 0.31%)}	_{+0.01s (+ 0.38%)}	_2.63s	_2.65s	_{p=0.050 n=6}
_{Check Time}	_{102.35s (± 0.66%)}	_{102.84s (± 1.08%)}	_~	_101.64s	_104.33s	_{p=0.471 n=6}
_{Emit Time}	_{0.32s (± 1.28%)}	_{0.32s (± 1.28%)}	_~	_0.31s	_0.32s	_{p=1.000 n=6}
_{Total Time}	_{117.25s (± 0.63%)}	_{117.80s (± 0.88%)}	_~	_116.67s	_119.17s	_{p=0.336 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,413,592k (± 0.02%)}	_{2,414,626k (± 0.02%)}	_{+1,034k (+ 0.04%)}	_2,414,006k	_2,415,601k	_{p=0.013 n=6}
_{Parse Time}	_{4.94s (± 0.71%)}	_{4.93s (± 0.78%)}	_~	_4.88s	_4.98s	_{p=0.747 n=6}
_{Bind Time}	_{1.87s (± 0.66%)}	_{1.88s (± 0.71%)}	_~	_1.86s	_1.90s	_{p=0.114 n=6}
_{Check Time}	_{33.71s (± 0.61%)}	_{33.86s (± 0.35%)}	_~	_33.64s	_33.99s	_{p=0.173 n=6}
_{Emit Time}	_{2.71s (± 1.54%)}	_{2.69s (± 1.15%)}	_~	_2.66s	_2.74s	_{p=0.332 n=6}
_{Total Time}	_{43.23s (± 0.52%)}	_{43.37s (± 0.27%)}	_~	_43.23s	_43.59s	_{p=0.109 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{418,957k (± 0.01%)}	_{419,270k (± 0.01%)}	_{+314k (+ 0.07%)}	_419,246k	_419,313k	_{p=0.005 n=6}
_{Parse Time}	_{2.79s (± 3.02%)}	_{2.81s (± 0.90%)}	_~	_2.77s	_2.84s	_{p=0.872 n=6}
_{Bind Time}	_{1.13s (± 6.20%)}	_{1.08s (± 0.00%)}	_~	_1.08s	_1.08s	_{p=0.176 n=6}
_{Check Time}	_{15.23s (± 0.22%)}	_{15.30s (± 0.31%)}	_{+0.08s (+ 0.53%)}	_15.24s	_15.38s	_{p=0.012 n=6}
_{Emit Time}	_{1.13s (± 1.07%)}	_{1.13s (± 1.20%)}	_~	_1.12s	_1.15s	_{p=0.934 n=6}
_{Total Time}	_{20.27s (± 0.21%)}	_{20.33s (± 0.28%)}	_~	_20.24s	_20.41s	_{p=0.091 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,848,471k (± 0.00%)}	_{2,848,483k (± 0.00%)}	_~	_2,848,442k	_2,848,525k	_{p=0.689 n=6}
_{Parse Time}	_{10.76s (± 0.31%)}	_{10.76s (± 0.36%)}	_~	_10.71s	_10.82s	_{p=0.935 n=6}
_{Bind Time}	_{3.42s (± 0.51%)}	_{3.44s (± 0.18%)}	_~	_3.43s	_3.45s	_{p=0.070 n=6}
_{Check Time}	_{60.70s (± 0.28%)}	_{61.02s (± 0.36%)}	_{+0.33s (+ 0.54%)}	_60.64s	_61.32s	_{p=0.037 n=6}
_{Emit Time}	_{16.28s (± 0.27%)}	_{16.24s (± 0.42%)}	_~	_16.18s	_16.37s	_{p=0.172 n=6}
_{Total Time}	_{91.16s (± 0.15%)}	_{91.46s (± 0.28%)}	_~	_91.00s	_91.72s	_{p=0.065 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{396,913k (± 0.01%)}	_{396,954k (± 0.02%)}	_~	_396,896k	_397,080k	_{p=0.689 n=6}
_{Parse Time}	_{3.15s (± 0.26%)}	_{3.15s (± 0.48%)}	_~	_3.14s	_3.17s	_{p=0.740 n=6}
_{Bind Time}	_{1.39s (± 0.71%)}	_{1.39s (± 0.60%)}	_~	_1.39s	_1.41s	_{p=0.273 n=6}
_{Check Time}	_{14.12s (± 0.19%)}	_{14.16s (± 0.22%)}	_{+0.04s (+ 0.31%)}	_14.11s	_14.19s	_{p=0.043 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.66s (± 0.15%)}	_{18.71s (± 0.25%)}	_~	_18.64s	_18.76s	_{p=0.072 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,425k (± 0.01%)}	_{513,555k (± 0.02%)}	_{+130k (+ 0.03%)}	_513,446k	_513,709k	_{p=0.013 n=6}
_{Parse Time}	_{3.28s (± 0.37%)}	_{3.28s (± 0.25%)}	_~	_3.27s	_3.29s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.595 n=6}
_{Check Time}	_{2.87s (± 0.68%)}	_{2.96s (± 1.27%)}	_{+0.10s (+ 3.37%)}	_2.91s	_3.01s	_{p=0.005 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.595 n=6}
_{Total Time}	_{7.77s (± 0.22%)}	_{7.87s (± 0.40%)}	_{+0.10s (+ 1.29%)}	_7.82s	_7.91s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,353ms (± 0.85%)}	_{2,348ms (± 0.37%)}	_~	_2,339ms	_2,364ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,559ms (± 1.36%)}	_{5,635ms (± 1.53%)}	_~	_5,553ms	_5,754ms	_{p=0.230 n=6}
_{Req 3 - references}	_{324ms (± 0.30%)}	_{323ms (± 0.23%)}	_~	_322ms	_324ms	_{p=0.109 n=6}
_{Req 4 - navto}	_{276ms (± 1.24%)}	_{276ms (± 0.81%)}	_~	_272ms	_278ms	_{p=0.869 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 8.40%)}	_{84ms (± 8.44%)}	_~	_79ms	_96ms	_{p=0.869 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,489ms (± 0.74%)}	_{2,487ms (± 0.88%)}	_~	_2,465ms	_2,517ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{4,173ms (± 1.82%)}	_{4,197ms (± 1.38%)}	_~	_4,169ms	_4,315ms	_{p=0.229 n=6}
_{Req 3 - references}	_{337ms (± 1.44%)}	_{334ms (± 0.49%)}	_~	_332ms	_336ms	_{p=0.376 n=6}
_{Req 4 - navto}	_{285ms (± 0.29%)}	_{284ms (± 0.43%)}	_~	_282ms	_285ms	_{p=0.183 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 5.54%)}	_{76ms (± 3.26%)}	_{🟩-11ms (-12.12%)}	_74ms	_79ms	_{p=0.012 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,618ms (± 0.30%)}	_{2,620ms (± 0.43%)}	_~	_2,604ms	_2,633ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{1,739ms (± 2.46%)}	_{1,761ms (± 2.48%)}	_~	_1,693ms	_1,816ms	_{p=0.298 n=6}
_{Req 3 - references}	_{127ms (± 1.07%)}	_{121ms (± 9.00%)}	_~	_106ms	_128ms	_{p=0.361 n=6}
_{Req 4 - navto}	_{371ms (± 0.42%)}	_{372ms (± 0.33%)}	_~	_370ms	_373ms	_{p=0.318 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{311ms (± 1.25%)}	_{311ms (± 1.43%)}	_~	_306ms	_317ms	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.85ms (± 0.21%)}	_{153.86ms (± 0.20%)}	_~	_152.55ms	_156.73ms	_{p=0.561 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.79ms (± 0.17%)}	_{229.83ms (± 0.19%)}	_~	_228.50ms	_238.64ms	_{p=0.837 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.26ms (± 0.18%)}	_{231.38ms (± 0.21%)}	_{+0.12ms (+ 0.05%)}	_229.80ms	_242.86ms	_{p=0.014 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.69ms (± 0.19%)}	_{231.79ms (± 0.19%)}	_{+0.10ms (+ 0.04%)}	_230.04ms	_239.97ms	_{p=0.001 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Feb 22 '24 21:02 typescript-bot

Hey @RyanCavanaugh, the results of running the DT tests are ready. Everything looks the same! You can check the log here.

Feb 22 '24 21:02 typescript-bot

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/57395/merge:

Something interesting changed - please have a look.

Details

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

calcom/cal.com

Raw error text: RepoResults7/calcom.cal.com.rawError.txt in the artifact folder

Last few requests

{"seq":760,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/apps/storybook/postcss.config.js","line":11,"offset":30,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":761,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/apps/storybook/postcss.config.js","line":11,"offset":39,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":" "}}
{"seq":762,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/pages/api/webhooks/[id]/_patch.ts"],"openFiles":[]}}
{"seq":763,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/swagger/lib/snippets.js","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

git clone https://github.com/calcom/cal.com --recurse-submodules
In dir cal.com, run git reset --hard 95d5824ba9b372dd2cda4ea3554631d3e9170a45
In dir cal.com, run yarn install --no-immutable --mode=skip-build
Back in the initial folder, download RepoResults7/calcom.cal.com.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./cal.com ./calcom.cal.com.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

Server exited prematurely with code unknown and signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

backstage/backstage

Raw error text: RepoResults8/backstage.backstage.rawError.txt in the artifact folder

Last few requests

{"seq":3321,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/create-app/src/lib/versions.ts","line":139,"offset":4,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":3322,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/create-app/src/lib/versions.ts","line":141,"offset":4}}
{"seq":3323,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/core-plugin-api/src/apis/system/ApiRef.ts"],"openFiles":[]}}
{"seq":3324,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/create-app/templates/default-app/packages/app/e2e-tests/app.test.ts","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

git clone https://github.com/backstage/backstage --recurse-submodules
In dir backstage, run git reset --hard 8cc5dd9d299ecc974c9f2b1dd9dc5ce0c6ab7a3d
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
2. In dir backstage, run yarn install --no-immutable --mode=skip-build
3. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
Back in the initial folder, download RepoResults8/backstage.backstage.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

Feb 22 '24 22:02 typescript-bot

@RyanCavanaugh - I guess this means I need to download the repos calcom/cal.com and/or backstate/backstage to confirm/recreate the problem - is that correct?

Feb 22 '24 22:02 craigphicks

Expand out the comment a few times and you'll get exact instructions on how to reproduce each.

Feb 22 '24 22:02 jakebailey

@RyanCavanaugh @jakebailey

Re: the cal.com report

After setting up according to the instructions the code in .../cal.com/node_modules/typescript/lib/tsserver.js does not include the changes in this pull #57395
However, the reported error can be reliably reproduced using tsreplay as described in the instructions.
Changing the hardcoded value in tsreplay giving the memory size for tsserver from 4096 to 8192 the error reliably disappears.

This is the output from ps when --max-old-space-size=

4096, reliably failing with final Exited unexpectedly with signal SIGABRT

node /workspaces/ts+dt/node_modules/.bin/tsreplay ./cal.com ./RepoResults7/calcom.cal.com.replay.txt cal.com/node_modules/typescript/lib/tsserver.js
usr/local/bin/node --max-old-space-size=4096 --expose-gc /workspaces/ts+dt/cal.com/node_modules/typescript/lib/tsserver.js --disableAutomaticTypingAcquisition

8192, reliably passing with final 999999 exit

node /workspaces/ts+dt/node_modules/.bin/tsreplay ./cal.com ./RepoResults7/calcom.cal.com.replay.txt cal.com/node_modules/typescript/lib/tsserver.js
usr/local/bin/node --max-old-space-size=8192 --expose-gc /workspaces/ts+dt/cal.com/node_modules/typescript/lib/tsserver.js --disableAutomaticTypingAcquisition

In the non-failing case, looking at system memory usage, it rises nearly monotonically with time to increase by 4.4 GiB.

I'll follow up by checking the other report too.

Feb 23 '24 07:02 craigphicks

Re: The backstage error report:

(1) The instruction specified path path/to/tsserver.js has some ambiguity.

There are 4 tsserver.js files in the project:

./node_modules/typescript/lib/tsserver.js
./node_modules/@microsoft/api-extractor/node_modules/typescript/lib/tsserver.js
./microsite/node_modules/typescript/lib/tsserver.js
./storybook/node_modules/typescript/lib/tsserver.js

Of those,

./node_modules/@microsoft/api-extractor/node_modules/typescript/lib/tsserver.js
./storybook/node_modules/typescript/lib/tsserver.js

differ from ./node_modules/typescript/lib/tsserver.js, while

./microsite/node_modules/typescript/lib/tsserver.js

is the same.

I have assumed that

./node_modules/typescript/lib/tsserver.js

is the one to use.

(2) However, none of those tsserver.js files contain the text checkOverloadsRelatedToIntersection which would be there if pull request 57395 had been merged.
(3) Just as in my previous post, increasing tsreplay memory from 4GB to 8GB prevented the error from happening.
(4) Differently from the report in the previous post, there were some ups and down in memory usage (not a monotonic increase) before the error.

Feb 23 '24 19:02 craigphicks

@typescript-bot test top200

Feb 24 '24 00:02 jakebailey

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 2d54894fd772e7c1ff1b154a2c734d2cd11f6b7b. You can monitor the build here.

Update: The results are in!

Feb 24 '24 00:02 typescript-bot

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/57395/merge:

Everything looks good!

Feb 24 '24 02:02 typescript-bot

@jakebailey - I am grateful and confused. I will look further into the SIGABRT examples.

Feb 24 '24 03:02 craigphicks

I would doubt that they are new in this PR; the server tests can be a little flaky.

Feb 24 '24 03:02 jakebailey

Didn't realize this wasn't accepted; will look if the feature is okay'd.

Feb 27 '24 19:02 jakebailey

This test case doesn't gets failed by the original code and doesn't get passed to the new function in the pull (which would pass it):

interface A {
    f(x:"a",y:string):1;
    f(x:"b",y:string):1;
    f(x:"c",y:string):1;
    f(x:"d",y:string):1;
    f(x:"e",y:string):1;
    f(x:"f",y:string):1;
};

interface B {
    f(x:"a",y:string):2;
    f(x:"b",y:string):2;
    f(x:"c",y:string):2;
    f(x:"d",y:string):2;
    f(x:"e",y:string):2;
    f(x:"f",y:string):2;
};
(0 as any as A) satisfies A&B;

So I have to check this before proceeding further.

Feb 28 '24 20:02 craigphicks

TypeScript TypeScript copied to clipboard

Pr issue 57087 - fix for relating (e.g. satisfies) function overloads to intersection specifications

Usage Scenario:

Current behavior

New Behavior

Implementation

Where

Algorithm

tsc

tsserver

startup

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

Last few requests

Repro steps

TypeScript
TypeScript copied to clipboard