TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard

Use more precise type: Canvas.createPattern

Open 3xau1o opened this issue 1 year ago • 1 comments

createPattern arg repetition type is widened to string

however According to MDN should be "repeat" | "repeat-x" | "repeat-y" | "no-repeat"

location in repo https://github.com/microsoft/TypeScript-DOM-lib-generator/blob/main/baselines/dom.generated.d.ts#L5747

current signature

createPattern(image: CanvasImageSource, repetition: string | null): CanvasPattern | null;

expected signature

type PatternRepeatMode = "repeat" | "repeat-x" | "repeat-y" | "no-repeat"

createPattern(image: CanvasImageSource, repetition: PatternRepeatMode | null): CanvasPattern | null;

3xau1o avatar Sep 24 '24 22:09 3xau1o