MSBuildForUnity icon indicating copy to clipboard operation
MSBuildForUnity copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

fix: MSBuild process output encoding

Open hikarin522 opened this issue 3 years ago • 4 comments

Fixed encoding of strings received from MSBuild process.

hikarin522 avatar Dec 20 '21 08:12 hikarin522

Not sure I understand the issue this is fixing...

jwittner avatar Jan 03 '22 17:01 jwittner

Thanks for the contribution @hikarin522! Will you add a comment explaining why this is needed? I guess it is trying to match the text encoding to whatever Unity is using? What happens when that is not done?

ryantrem avatar Jan 03 '22 19:01 ryantrem

If the system language is Japanese, MSBuild will be output as CP932, which will cause garbled characters. Similar problems may occur in other languages.

hikarin522 avatar Jan 04 '22 03:01 hikarin522

Below is an image of a PackageReference typo error.

  • before image

  • after image

hikarin522 avatar Jan 04 '22 05:01 hikarin522