MLOS icon indicating copy to clipboard operation
MLOS copied to clipboard

mlos_bench: Trial repetition

Open yshady opened this issue 1 year ago • 6 comments
trafficstars

I would like to run each config 30 times but not 30 at same time. For example, a default config should be running 30 times but not concurrently.

Currently trial repeat param for mlos_bench will run the trial repeat number all at the same ts_start

yshady avatar Jun 24 '24 23:06 yshady

Chatted about this, there is some confusion over some storage entries, but they aren't running concurrently (yet).

We should

  • [ ] add ts_create to the DB to note when a trial was "created" vs when its (scheduled to) start(ed)
  • [ ] add support for specifying "(random) splay between" trial repeats in the configs
  • [ ] enable the scheduler to only start trials with current or past ts_start

bpkroth avatar Jun 26 '24 20:06 bpkroth

@motus I don't think all of this is handled yet, so reopening.

bpkroth avatar Jul 11 '24 15:07 bpkroth

@eujing can you see if trial repeat with master is still broken? I observed it acts like a minimum bound and not as a maximum

yshady avatar Jul 25 '24 05:07 yshady

@yshady trial repeat seems to be working at an exact value when using the main branch. I have been using 1, and getting new configs proposed every time. Maybe this is not an issue anymore in the main branch.

eujing avatar Jul 25 '24 17:07 eujing

I was using 5 or more

yshady avatar Aug 02 '24 20:08 yshady

Should probably just write a test for this.

bpkroth avatar Aug 08 '24 22:08 bpkroth