MLOS
MLOS copied to clipboard
Change formatter to black to strongly enforce pep8 style
Previously this project used autopep8. This did not automatically enforce many aspects of style causing many files to use different styles. Additionally not all standards in pep8 were being enforced.
This PR attempts to solve this by switching to black, a more aggressive style formatter, while also bringing all files in compliance to ensure a uniform style.
All changes outside of the makefile, and .vscode were made using the formatted itself.
@jsfreischuetz please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"Contributor License Agreement
@microsoft-github-policy-service agree
When we're done with this one, let's add a new .gitrevisions entry so we don't mess with the history too much.
Playing with this locally atm. I have some changes to the Makefile rules prepped. Also we'll need to add config options in pyproject.toml which will cause other required changes elsewhere, so I'll try and prep those first and then come back to this.
Playing with this locally atm. I have some changes to the Makefile rules prepped. Also we'll need to add config options in pyproject.toml which will cause other required changes elsewhere, so I'll try and prep those first and then come back to this.
#762 and #763 have some Makefile improvements to prepare for this. #764 introduces pyproject.toml changes #766 prepares isort and black format checkers
Will take up the actual reformatting and enablement of those after those are thru.
Closing this one for now.