FLAML icon indicating copy to clipboard operation
FLAML copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Inconsistent naming

Open hannahbus opened this issue 1 year ago • 1 comments
trafficstars

Many thanks for a great package.

I've noticed a small inconsistency concerning random forests: the key in foo.best_config() is max_leaves, which differs from sklearn's max_leaf_nodes.

hannahbus avatar Apr 10 '24 12:04 hannahbus

I have created an PR #1310 to fix the issue mentioned...

Programmer-RD-AI avatar May 28 '24 06:05 Programmer-RD-AI

I have created an PR #1310 to fix the issue mentioned...

Hi @Programmer-RD-AI , #1310 won't fix the issue, I've raised #1320 to address it.

thinkall avatar Jul 22 '24 13:07 thinkall

Check https://github.com/microsoft/FLAML/pull/1320#issuecomment-2244505018 for more details why this won't be fixed.

thinkall avatar Jul 23 '24 07:07 thinkall