FLAML icon indicating copy to clipboard operation
FLAML copied to clipboard

Typo or misnaming in automl/timeseries/ts_model.py

Open enkiluv opened this issue 1 year ago • 1 comments
trafficstars

In version 2.x.x: (especially 2.1.1)

Lines 613 and 616: if ( self.params["seasonal"] == "mul" and (train_df.y == 0).sum() > 0 ): # cannot have multiplicative seasonality in this case self.params["seasonal"] = "add" if self.params["trend"] == "mul" and (train_df.y == 0).sum() > 0: self.params["trend"] = "add"

train_df.y == 0 should be train_df[target_col] == 0 . Isn't it? (two places)

enkiluv avatar Feb 19 '24 07:02 enkiluv

Hi, I have created a PR #1312 feel free to check it :) Best regards

Programmer-RD-AI avatar May 29 '24 10:05 Programmer-RD-AI