DirectXShaderCompiler icon indicating copy to clipboard operation
DirectXShaderCompiler copied to clipboard

Fix broken ternary on matrix return type (#4434)

Open llvm-beanz opened this issue 3 years ago • 5 comments

HLSL ternary operators that result in vector or matrix types need special handling even if the condition is not a vector. This change allows vector and matrix result types for ternary operators even if matrix and vector conditions are not allowed.

Preventing matrix and vector conditions is done in Sema, so we should never be able to reach this code path with a matrix or vector condition unless the HLSL language version is < 2021.

Fixes #4434

llvm-beanz avatar May 16 '22 16:05 llvm-beanz

:white_check_mark: Build DirectXShaderCompiler 1.0.1640 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/dceecbcb0f by @llvm-beanz)

AppVeyorBot avatar May 16 '22 17:05 AppVeyorBot

Test failures are due to our preservation of value names in debug builds.

tex3d avatar May 16 '22 17:05 tex3d

:x: Build DirectXShaderCompiler 1.0.1648 failed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/8575694977 by @llvm-beanz)

AppVeyorBot avatar May 16 '22 23:05 AppVeyorBot

:white_check_mark: Build DirectXShaderCompiler 1.0.1654 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/71022e86c2 by @llvm-beanz)

AppVeyorBot avatar May 17 '22 18:05 AppVeyorBot

:white_check_mark: Build DirectXShaderCompiler 1.0.1682 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/cb0063e9c3 by @llvm-beanz)

AppVeyorBot avatar May 23 '22 18:05 AppVeyorBot

:x: Build DirectXShaderCompiler 1.0.1988 failed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/fbfdc4f3a6 by @llvm-beanz)

AppVeyorBot avatar Sep 13 '22 00:09 AppVeyorBot

:white_check_mark: Build DirectXShaderCompiler 1.0.2040 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/200257435b by @llvm-beanz)

AppVeyorBot avatar Sep 19 '22 17:09 AppVeyorBot

:white_check_mark: Build DirectXShaderCompiler 1.0.2045 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/44290d2355 by @llvm-beanz)

AppVeyorBot avatar Sep 19 '22 22:09 AppVeyorBot