DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

[deepspeed/autotuner] Bug fix for binary search for batch size

Open rahilbathwal5 opened this issue 3 years ago • 5 comments
trafficstars

The current implementation terminates when low = high - 1 and in the process skips checking high as a possible value for the max_micro_batch_size.

rahilbathwal5 avatar Aug 01 '22 23:08 rahilbathwal5

@rahilbathwal5, thanks for this PR. Could you please update the branch?

tjruwase avatar Aug 02 '22 13:08 tjruwase

@tjruwase Done, pulled in the latest from DeepSpeed master.

rahilbathwal5 avatar Aug 02 '22 19:08 rahilbathwal5

@rahilbathwal5, thanks for the PR!

cli99 avatar Aug 02 '22 20:08 cli99

@thanks for the PR

cli99 avatar Aug 02 '22 20:08 cli99

@rahilbathwal5, I am not sure why we are unable to update this branch with master. Because we have some many PRs being merged, your branch quickly gets out-of-date preventing merge. Did you do something different with this PR?

@jeffra and @mrwyattii for suggestions.

tjruwase avatar Aug 05 '22 11:08 tjruwase