BotBuilder-Location icon indicating copy to clipboard operation
BotBuilder-Location copied to clipboard

Modified facebook-location-dialog to fall back to default-location-di…

Open bernardoleary opened this issue 8 years ago • 3 comments

In this Facebook chat windows the "Send Location" option is presented, but is not able to be used: image This message is displayed to the user, and then they are stuck, because there is no other location entity option: image My pull request resolves this situation by allowing an option to specify a text-based input instead (the pull request prompts with more generic text than this screenshot): image BotBuilder-Location is a great component. Any questions about my request, please ask!

bernardoleary avatar Jan 09 '17 01:01 bernardoleary

Hi @bernardoleary ! Nice work! What happened with this PR?

manuga93 avatar Jul 05 '18 20:07 manuga93

Hi @garridev thanks! Funny you should ask - I had just revisited this yesterday. At the time I became busy with something else and never came back to it. Will aim to sort out the issues that were identified and resubmit over the weekend - let me know if you have any suggestions!

bernardoleary avatar Jul 05 '18 20:07 bernardoleary

hehe, that's funny! Your welcome mate. I've been done a fork where I've merged your commit and have resolved conflicts. I've translate all to Spanish as well ;)

manuga93 avatar Jul 06 '18 15:07 manuga93