BitNet icon indicating copy to clipboard operation
BitNet copied to clipboard

check for build requirements and abort build process if not satisfied

Open bmerkle opened this issue 1 year ago • 4 comments

  • python>=3.9
  • cmake>=3.22
  • clang>=18 on windows use the msvc-clang (>=17)

fix https://github.com/microsoft/BitNet/issues/34

bmerkle avatar Oct 19 '24 22:10 bmerkle

@potassiummmm can you have a look at this? IMO checking for prerequisites will avoid a lot of user bug reports 😉.

bmerkle avatar Nov 06 '24 18:11 bmerkle

merge conflict resolved

bmerkle avatar Nov 06 '24 18:11 bmerkle

Thanks for your work! We are working on resolving toolchain dependencies, so the current version limitations may not be mandatory.

potassiummmm avatar Nov 08 '24 05:11 potassiummmm

@potassiummmm I understand. However in our build environment / embedded area we usually check for tool names and also tool versions, so IMO we are on a safer side if we check it (at least the minimal required versions). And the implementation is already there with this patch/PR :-) What do you think ?

bmerkle avatar Nov 13 '24 21:11 bmerkle