ApplicationInsights-dotnet icon indicating copy to clipboard operation
ApplicationInsights-dotnet copied to clipboard

[Prototype] Support ActivityLinks

Open pakrym opened this issue 4 years ago • 10 comments

Currently, Azure SDKs produce a special kind of Activities that carries links in a

public IEnumerable<Activity> Links { get; }

property.

Migration to ActivitySource based activities would result in the same information being carried in the https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.activity.links?view=net-5.0

This PR add support for collecting both ways of representing links.

pakrym avatar Mar 10 '21 00:03 pakrym

/AzurePipelines run

TimothyMothra avatar Mar 10 '21 00:03 TimothyMothra

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Mar 10 '21 00:03 azure-pipelines[bot]

cc @lmolkova

pakrym avatar Jun 22 '21 23:06 pakrym

Hey, @TimothyMothra @cijothomas!

We made the change on Azure SDK side to add an experimental ActivitySource support. How can I help you make a decision on this PR?

pakrym avatar Oct 06 '21 21:10 pakrym

/AzurePipelines run

TimothyMothra avatar Oct 06 '21 21:10 TimothyMothra

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 06 '21 21:10 azure-pipelines[bot]

Test failures seem unrelated.

pakrym avatar Oct 06 '21 22:10 pakrym

/AzurePipelines run

TimothyMothra avatar Oct 07 '21 00:10 TimothyMothra

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 07 '21 00:10 azure-pipelines[bot]

@rajkumar-rangaraj any news on this? The .NET 5 activity link support has shipped in Azure SDKs

pakrym avatar Dec 10 '21 16:12 pakrym

This PR is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

github-actions[bot] avatar Oct 07 '22 00:10 github-actions[bot]