ABAP-SDK-for-Azure icon indicating copy to clipboard operation
ABAP-SDK-for-Azure copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Namespaces

Open larshp opened this issue 7 years ago • 7 comments
trafficstars

Hi, The repository contains some objects with quite generic names, eg: FUGR ZREST TABL ZREGISTER DOMA ZCLASSNAME DTEL ZCHAR75 DTEL ZORIGINAL DTEL ZURI DTEL ZUNAME For these, there is a theoretical chance that the customer already has an object with identical names in their system.

I recommend prefixing objects to lower the risk, eg. FUGR Z_AZURE_REST TABL Z_AZURE_REGISTER DOMA Z_AZURE_CLASSNAME DTEL Z_AZURE_CHAR75 DTEL Z_AZURE_ORIGINAL DTEL Z_AZURE_URI DTEL Z_AZURE_UNAME or something similar

larshp avatar Jun 02 '18 09:06 larshp

Thanks for the feedback. We are working on this.

krdash avatar Jun 02 '18 16:06 krdash

@larshp - We are looking into your suggestion for getting a unique Namespace. I have one query on ABAPGit to understand whether ABAPGit would show any object overwriting warnings while doing the pull or clone from the repository to SAP system. Thanks

krdash avatar Jun 02 '18 16:06 krdash

unique namespace: in my opinion it is easier just to prefix

overwrite: yes it shows warnings if the objects it tries to overwrite are outside of the expected package hierarchy(main repo package)

larshp avatar Jun 02 '18 19:06 larshp

@krdash So, is ZxxADFxx the actual prefix Namespace (e.g. ZCL_ADF_..., ZADF_S_STRUC...)? Should we move ZREST to ZADF one by one?

bigld avatar Jun 04 '20 08:06 bigld

What is the status on this? It seems to me that the correct way to do it is to introduce a proper name space, instead of customer namespace Z... For instance /AZURE/ Everything else will cause problems at some point...

atarigui avatar Nov 17 '21 11:11 atarigui

Namespace must be Z or Y! For reserved Namespaces like /AZURE/ one needs special key (producer/repair) to create objects in this namespace!

bigld avatar Nov 17 '21 14:11 bigld

The problem is that this comes with name conflicts, which can not be prevented as long as the objects are in Z (customer) name space. ref other issue #41 . Maybe the repair key could be shared (similar to DEMO objects in SAP)? See for instance this

atarigui avatar Nov 17 '21 15:11 atarigui

Thanks @larshp for the feedback,

We are working towards unified namespace for the next release will keep you posted.

Regards, Vikas

vikasbansal2022 avatar Nov 30 '22 07:11 vikasbansal2022

cool

one tip, you can setup abaplint to automatically check the objects have the preferred prefix, example at https://github.com/abapGit/abapGit/blob/main/abaplint.json#L335-L339

larshp avatar Nov 30 '22 07:11 larshp