ABAP-SDK-for-Azure icon indicating copy to clipboard operation
ABAP-SDK-for-Azure copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Update AAD Token V2

Open kritchaponc opened this issue 3 years ago • 7 comments
trafficstars

Add Method for GET AAD Token for Azure AAD OAuth V2 by replacing resource to scope

kritchaponc avatar Mar 21 '22 08:03 kritchaponc

CLA assistant check
All CLA requirements met.

microsoft-cla-retired[bot] avatar Mar 21 '22 08:03 microsoft-cla-retired[bot]

https://github.com/microsoft/ABAP-SDK-for-Azure/pull/94 handles the 2 issues with OCCURS

larshp avatar Mar 21 '22 08:03 larshp

There're some services like Service Now that require Azure AD Connect V2.0. Currently, this SDK only support V1.0 so I create the new method and change a few parameter from resource (v1) to scope (v2).

kritchaponc avatar Mar 21 '22 08:03 kritchaponc

Need to redefine and add some enhancement so decide to close the PR for now.

kritchaponc avatar Mar 22 '22 03:03 kritchaponc

@larshp Hi Lars Hvam,

Is it possible to merge this PR into main branch ? Currently many service required AAD Token version 2 and changes include

  1. Clone Get AAD Token method
  2. Change Parameter name from resource -> scope. Or if there are anything I have to provide can you give me a suggestion? Best Regards,

kritchaponc avatar Apr 11 '22 07:04 kritchaponc

I dont have access, I'm not a maintainer of this repo

larshp avatar Apr 11 '22 07:04 larshp

@larshp Okay my apologize xD. So who can I tag in this case? @Naveen-Kurmadas ?

kritchaponc avatar Apr 11 '22 09:04 kritchaponc

Thanks @kritchaponc for making contribution to the Repo.

Instead of changing the code and changing the Resource to scope. you can setup RFC connection with OAUTH2 URL and ZCL_ADF_SERVICE_AAD~GET_AAD_TOKEN will give you the token.

Please let me know if you have any other thoughts.

image

vikasbansal2022 avatar Nov 14 '22 07:11 vikasbansal2022