react-json-view icon indicating copy to clipboard operation
react-json-view copied to clipboard

:heavy_minus_sign: Removing "react-hot-loader" package

Open VadimZvf opened this issue 1 year ago • 2 comments

This package is deprecated and there's no plans to support it for React 18. https://github.com/gaearon/react-hot-loader/issues/1808#issuecomment-1279728183

What do you think if we remove it? The webpack hot module replacement works well even without "react-hot-loader".

The problem I'm trying to solve is this error: Screenshot 2024-08-16 at 15 58 45

Also I wanna update some dependencies to resolve all similar dependency errors.

VadimZvf avatar Aug 16 '24 14:08 VadimZvf

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 8:09pm

vercel[bot] avatar Aug 16 '24 14:08 vercel[bot]

Also, this package wasn't used 😀 We don't use it in the webpack config https://github.com/microlinkhq/react-json-view/blob/master/webpack/webpack.config.js#L37

VadimZvf avatar Aug 16 '24 15:08 VadimZvf

This is a good catch, thanks for it 🙂

Kikobeats avatar Sep 11 '24 20:09 Kikobeats