GmsCore icon indicating copy to clipboard operation
GmsCore copied to clipboard

Checking deprecated permission.C2D_MESSAGE possibly breaking cloud messages

Open ghost opened this issue 4 years ago • 2 comments

Hi.

(Sorry for bad English)

User Dark Simpson asked interesting question in a microG thread on 4pda >> URL <<

He suggested that telegram app does not receive cloud messages correctly due to a missing deprecated C2D_MESSAGE permission check.

https://github.com/microg/GmsCore/blob/a830b5dd5de71fa53f9d037c210a81fb38ea3321/play-services-core/src/main/java/org/microg/gms/gcm/McsService.java#L535-L546

So do we really need to check this permission ? Migrating from Google Cloud Messaging (GCM) to Firebase Cloud Messaging (FCM)

And one more question from me: Is it normal that whitelisting doesn't happen for third party apps? https://github.com/microg/GmsCore/blob/a830b5dd5de71fa53f9d037c210a81fb38ea3321/play-services-core/src/main/java/org/microg/gms/gcm/McsService.java#L561-L570 Or have I misunderstood something?

Thanks.

ghost avatar May 19 '21 21:05 ghost