python-editor-v3
python-editor-v3 copied to clipboard
Use extracted (alpha) connection library
This PR is expected to hang around for a bit as we evolve the connection library interface.
Issues specific to the integration:
- [ ] x2 deps on Intel hex library (due to fixed version dep?)
- [ ] bundle size check needed. The connection lib includes hex-related dep that we don't use - is it bundled?
Preview build will be at https://review-python-editor-v3.microbit.org/connection/
Everything seems to be working OK as of https://github.com/microbit-foundation/python-editor-v3/pull/1190/commits/ec290dd14b6e19024cd2f19373fa3b6e24a6011b
Not sure if this PR is ready for review, but I have installed the latest version of connection and fs library. I tried full and partial flashing my micro:bit with a Python project. It LGTM
Bundle size comparison from running npm run build:
main branch | 2,030.66 kB
connection branch | 2,042.52 kB
It looks comparable to me