micro_ros_espidf_component icon indicating copy to clipboard operation
micro_ros_espidf_component copied to clipboard

make micro ros epsidf work with IDF 5

Open sebastianohl opened this issue 3 years ago • 4 comments

This pull request enables building micro ros with ESP IDE 5

To test is, a new Dockerfile referencing to IDF 5 is also included.

Changes:

  • Adding a few includes
  • fixing a bad format in int32_publisher (may also be needed with the other examples, but i was only testing with this one)
  • Pull request "Update CMakeLists.txt # 160" ist also included.

Tested with EPS32S3 with included docker container and also with platform.io ESP IDF 5.1.1 platform

sebastianohl avatar Sep 28 '22 14:09 sebastianohl

Hello, @sebastianohl thanks a lot for this contribution!!

Can you add this to the CI and also to the README.md ?

pablogs9 avatar Sep 28 '22 15:09 pablogs9

hope that its complete now. let's see what to CI says...

sebastianohl avatar Sep 29 '22 13:09 sebastianohl

finally the ci is working. this build system is not very handsome for integrating new frameworks...

sebastianohl avatar Sep 30 '22 12:09 sebastianohl

@sebastianohl feel free to propose any improvement to the build system

pablogs9 avatar Sep 30 '22 13:09 pablogs9

please merge this

CasCard avatar Jan 23 '23 13:01 CasCard

@CasCard does it compile successfully? Which hardware if yes? I have checked recently and there was an issue with types (linux amd64, mac m1 arm64) probably due to freertos includes. Haven't explored further

anslex avatar Jan 23 '23 15:01 anslex

sorry @CasCard in which esp hardware have you tested this ????

ALUIS97 avatar Jan 28 '23 22:01 ALUIS97

There was an issue with the C standard version of some of micro-ROS packages, which has been solved on our side. We are including your update with some fixes on this PR: https://github.com/micro-ROS/micro_ros_espidf_component/pull/176

Closing, feel free to provide any feedback if you test our implementation with the v5 version.

Acuadros95 avatar Feb 16 '23 08:02 Acuadros95