combobulate icon indicating copy to clipboard operation
combobulate copied to clipboard

Published 20 hours ago • verified publisher icon mickeynp

Warnings from transient

Open stevemolitor opened this issue 1 year ago • 1 comments

I upgraded transient to version 0.5.3. I now get these warnings when I start combobulate-mode:

WARNING: transient-define-prefix: When :setup-children is used, :class must also be specified

stevemolitor avatar Mar 15 '24 15:03 stevemolitor

Hi Steve. Yeah this was reported earlier. It's apparently a bug in transient, but I've added a fix locally that I'll deploy soonish.

mickeynp avatar Mar 22 '24 08:03 mickeynp

It's not a bug. Transient looks at the structure of the specification, to determine the appropriate class of the root class. If there is no structure, because the children are determined at a later time using an arbitrary function, then you must specify the class explicitly. Also see https://github.com/magit/transient/commit/beecdc85799231338314bd20292f71fc8cd687e8.

tarsius avatar Apr 14 '24 14:04 tarsius

Thanks. I've already deployed the fix we spoke about in the GH issue I raised.

mickeynp avatar Apr 14 '24 16:04 mickeynp