lazy_high_charts icon indicating copy to clipboard operation
lazy_high_charts copied to clipboard

Published 20 hours ago • verified publisher icon michelson

Application.js step needs to be included in installation

Open BrennonTWilliams opened this issue 11 years ago • 5 comments
trafficstars

I just now saw someone else made an issue for this, but I went ahead and made a pull request for it. I lost a good half hour to trying to figure out why the gem wasn't working before I tried adding high charts to application.js, specifying this in the Readme may make it easier for the next guy.

BrennonTWilliams avatar Jul 30 '14 22:07 BrennonTWilliams

@BrennonTWilliams Sorry for that bad experience. how about give a pull request?

xiaods avatar Aug 03 '14 13:08 xiaods

fixed #172 merged.

xiaods avatar Aug 03 '14 13:08 xiaods

@xiaods , @BrennonTWilliams why is needed to add highcharts before require_tree . ?

look at this example. it is not required to put the hc lib before require_tree https://github.com/michelson/lazy_high_charts/blob/master/spec/dummy_rails/app/assets/javascripts/application.js

michelson avatar Aug 03 '14 16:08 michelson

@michelson the dummy project contains wrong setting for highchart.

Need a patch to fix it. @BrennonTWilliams 's patch focus on README have not clear definition.

xiaods avatar Aug 04 '14 01:08 xiaods

I needed to add to application.js as well in Rails. See this answer on SO: http://stackoverflow.com/a/26569321/1974564

HansHauge avatar Feb 01 '15 17:02 HansHauge