Michael Kotten

Results 76 comments of Michael Kotten

Oh great. Yes that's the problem. See https://github.com/bohdan-s/SunGather/blob/main/requirements.txt#L3. `paho-mqtt>=1.5.1` includes also 2.0.0 🤦‍♂️

Thanks for your efforts, but there is already a `/metrics` endpoint in the webserver exporter (https://github.com/bohdan-s/SunGather/commit/bca665ade308027a5ce4b143e6d99a073a262727). Maybe you could extend this one? I don’t think we need an extra exporter.

I still don’t see the need for a dedicated exporter. You can reuse and change/fix the current `/metrics` endpoint. It makes no sense to have two endpoints for prometheus. I...

@Ranhiru just extend/replace the existing one. I think the endpoint should still be /metrics. Since it will be a new release version we can replace it and people can switch...

> Do I add some example configuration and leave it up to the user to fill in the rest ? I think that's ok for now. But for the future...

Basically I like the implementation. What I don't like is the rather complex configuration. That's what I like about the current implementation which just exports all registers. Would be great...

> maybe we should add some Info to the README.md about the ability to use ENV and how to use it Done

You can use https://pypi.org/project/modbus-proxy/. There’s also a docker image at https://hub.docker.com/r/tiagocoutinho/modbus-proxy. You just have to point the proxy to your inverter and sungather, OpenHab etc. to the proxy then.

I guess we could add this to the exiting release pipeline: https://github.com/marketplace/actions/pypi-publish

I don't think that a downgrade of k3s can be a solution for this. Please reopen!