Michal Kleiner

Results 192 comments of Michal Kleiner

I'll mark this as an enhancement as it's an edge-case.

Hello! Thank you for raising the issue and apologies it hasn't been responded to earlier. We can look into the custom attributes vs the `$AttributesHTML` variable. If your issue is...

This PR might be relevant to this issue, would it solve your issue sufficiently? https://github.com/unclecheese/silverstripe-display-logic/pull/137

Hello! Thank you for raising the feature request and apologies it hasn't been responded to earlier. If you can provide a PR, we will definitely consider it. Using vanilla JS...

@mikeyc7m still keen to look at this and provide a PR? If not, feel free to close the issue. Thanks!

Thanks for starting the PR @lutdev. Is there a reason to have the properties public? Are they used outside of the class? I'd imagine they can be private, protected at...

Hi @lutdev. Just a quick question here — the issue seemed more like a question (are we going to remove legacy PHP support?) rather than an issue or bug. I...

> @michalkleiner yes, it was a question, for sure. I decided to drop the support 7.0 version because with it we can't use features that 8.1+ provides for us. >...

> @michalkleiner perfect!) What are the next steps? What should I do? Would be great if we update CHANGELOG.md, but what version should we mention? Let's reinstate the constant that...

@sgiehl this is now fine with me. Is it ok to merge this and tag `3.3.0`?