Michael Jones

Results 5 comments of Michael Jones

In general we assume that when we're including the standalone headers (stddef, inttypes, etc.) they are coming from the compiler. This is to avoid this exact sort of compatibility issue...

Hi, Sorry it's taken a while to get back to you. I have a theory as to what the problem is. My guess is that valgrind is expecting all `::FILE`...

Since the issue is that the implicit conversion to bool is failing, the easiest solution is likely to add a `static_cast` to the statement.

@arsenm I assume you mean for the GPU implementation? The generic implementation looks correct already since we have to support both clang and GCC.

> So I can remove the amdgpu stuff right? Yes, we can add them back in a followup patch if needed.