Michael Osthege

Results 202 comments of Michael Osthege

Thanks for opening such a detailed issue! I edited the formatting in your comment and added a link to that line. ----- I'm not familiar with the implementation, but is...

> However, could you explain what you mean with "we cast to int32 and not to int64 is that the latter can overflow float64 calculations for large integer values"? It's...

> In addition, I would suggest to rename the pandas_to_array function to a more informative name. Heads-up, the `pandas_to_array` is being renamed to `convert_observed_data` by #5743.

> I think this will also drop all text variables? With the last push I included modified the coords dropping to have one `str` coordinate and it's not dropped. The...

I don't think `object` is valid for strings. See https://github.com/arviz-devs/arviz_example_data/pull/8 where now the `"school"` coordinate is of `

> Also to enable adding strings to a particular array of strings basically need to use object type. Unfortunately it appears you're right.. When I updated the `(non-)center_eight` `InferenceData` in...

Yes, I have made my PyMC changes independent of this, and more informative errors at the xarray level sound great

Issue template types we should add: + Feature request (needs motivation, possibly implementation proposal) + Maintenance ToDo (needs motivation, todo-list) + Question? (direct people to Discussions or Discourse)

> We need an issue template for development/ feature request. None of the current ones fit. @ferrine added one, but GitHub doesn't like it: https://github.com/pymc-devs/pymc/blob/main/.github/ISSUE_TEMPLATE/feature-request.yml not sure why