Michael Gregorius
Michael Gregorius
@bratpeki, I propose to merge this as is. If something needs to be changed it is simple to do. The gist of it is (applies to `Knob` and `TempoSyncKnob`): *...
> Looking at it now, it might be nice to make them a bit bigger, although I feel like this is perfectly readable. Asking `@tresf` and @rubiefawn for thoughts. If...
> In that case, it'd be good to stick to the new implementation. Is the space between the knob and the text fixed? Maybe a bigger text and smaller padding...
@bratpeki, @szeli1, can you please approve?
It works under X11 and therefore only is a problem under Wayland. It is caused by the calls to `devicePixelRatio()` here: https://github.com/LMMS/lmms/blob/18252088ba1dcbf5218e0bf7cb6604522a64185c/plugins/Vectorscope/VectorView.cpp#L254 And here: https://github.com/LMMS/lmms/blob/18252088ba1dcbf5218e0bf7cb6604522a64185c/plugins/Vectorscope/VectorView.cpp#L256 The method `devicePixelRatio()` returns 2...
There's also a problem with the general functionality under Wayland. The screen is not cleared if HQ mode is disabled but everything works in HQ mode: [Broken Vectorscope in Non-HQ.webm](https://github.com/user-attachments/assets/1ae08b39-e51c-471c-8ea7-40062103a228)
With the fix described above the broken rendering starts to appear when the value of the variable `displayWidth` is equal or greater than `activeSize`.
Did you test it under Linux with Wayland, @bratpeki? It seem that upscaling pixmaps does not work on that platform like it works on X11.
> > I am not sure why it is necessary to use the device/pixel ratio here. > > Basically in all my LMMS work, I use this in context of...
> @michaelgregorius How much effort would it take to make LMMS working properly on Wayland? It's hard to tell. The issues have to be found in the first place. And...