Michael Gregorius

@DomClark, it seems that you are currently on a review run. :sweat_smile: Can you please check this pull request as well? In my opinion it improves the readability in the...

This is caused in the constructor of `VibratingString.cpp`. Line 46 seems to be the relevant line: https://github.com/LMMS/lmms/blob/71dd300f43d6c1e69cbf1362174a8747427ff248/plugins/Vibed/VibratingString.cpp#L46 `m_oversample` is 0 here which means that `stringLength` becomes 1. Why is `m_oversample`...

IMO the plugins should only know about the sample rate that the DAW tells it to process data at. This is the sample rate at which audio is coming in...

I have a branch called "LmmsComboBox" that introduces a combo box that inherits from `QComboBox` and that knows how to deal with `ComboBoxModel`. It can be found here: https://github.com/michaelgregorius/lmms/tree/LmmsComboBox. I...

I have now pushed some changes for the microtuner configuration. Here's a before and after of the microtuner dialog:   Looks much more consistent IMO and removes the crashes...

@messmerd, I think it's better to create a new class and to get rid of `ComboBox` wherever possible. It has several problems, e.g. that it does not play nice with...

@zonkmachine, @YurkoFlisk, for me the change removes the click. I am not sure though if the ADSRs are implemented correctly in the first place. I'm under the impression that the...

If I understand correctly then this is quite different to how ADSRs work in others DAWs and synths and so obviously also confusing to users who have experience with ADSRs....

The question is what kind of fix is intended. As noted above the same ADSR envelope should be calculated for an amount of 1 and amount of 0.01. In the...

Regarding the ADSRs I am under the impression that one could differentiate between two implementations: * "Analogish": The current value of a slope is computed using a multiplicative factor `f`....