Mike Beaumont

Results 180 comments of Mike Beaumont
trafficstars

Buggy behavior from dependabot here? Looking at https://github.com/kumahq/kuma-website/security/dependabot/47 we see that `4.1.0` is vulnerable, which [is in `yarn.lock`](https://github.com/kumahq/kuma-website/blob/245b01b1c5d78e57530497821010ede15cba4492/yarn.lock#L1695). But we see "No security update is needed as ansi-regex is no...

Yeah seems done, `to` is only under gateway

:+1: This is definitely something we discussed before I think A little bit in https://github.com/kumahq/kuma/issues/6417 and definitely in PRs where we introduced the plugin structure. We should ideally be working...

@lahabana @jakubdyszkiewicz what information was it we needed before we work on this?

@lahabana it's a missing feature. The impetus was that there are new Gateway API tests that test forwarding to Services with manually managed EndpointSlices. Which will prevent us from moving...

Yeah we've struggled with this, it's a [pretty nasty shortcoming](https://github.community/t/make-secrets-available-to-builds-of-forks/16166/35) IMO. Ultimately I suppose there needs to be a step built into github like "trust this PR". Nothing related appears...

Nice, this actually solves the problems I was having straight away, I only wanted to merge PRs so didn't need the fork code at all. It looks like with `pull_request_target`...

> Was this causing any problem? Not that I know of, but the code is just incorrect. Especially important for https://github.com/kumahq/kuma/pull/10160

Also `wait` wasn't deprecated, it was just broken immediately. https://github.com/siderolabs/terraform-provider-talos/pull/105 removed the logic but left the parameter. That's not really deprecation and it's actually kind of worse than just removing...