aiocomfoconnect icon indicating copy to clipboard operation
aiocomfoconnect copied to clipboard

Update PROTOCOL-PDO.md

Open hsmade opened this issue 1 year ago • 4 comments

-1 doesn't exist in UINT, so I converted them to what the value would be in the respective UINTs

hsmade avatar Mar 23 '24 18:03 hsmade

I must admit that at least 4294967295 looks like a magic number. Is not possible to use a more intuitive and clear syntax: 0xFF for 8 bit and 0xFFFF for 16 bit numbers?

denmaus avatar Mar 23 '24 20:03 denmaus

I agree with @denmaus, while you are technically correct that it's impossible to specify a negative number with an unsigned int, it does make it more clear what the values mean by just indicating a negative number.

I prefer this clarity. Maybe a note below the table to indicate this might be better?

michaelarnauts avatar Mar 29 '24 18:03 michaelarnauts

Maybe: -1 (0xFFFF) ?

hsmade avatar Mar 29 '24 18:03 hsmade

Maybe: -1 (0xFFFF) ?

That's also fine I guess :)

michaelarnauts avatar Jun 07 '24 17:06 michaelarnauts