flask-rest-jsonapi icon indicating copy to clipboard operation
flask-rest-jsonapi copied to clipboard

schema.py: Fix for get_nested_fields

Open aditya-bhawsingka opened this issue 5 years ago • 3 comments
trafficstars

Having a list field on schema is giving an error after upgrading to the latest version. The get_nested_fields function is trying to access an attribute 'container' on a list field, which as per latest marshmallow version does not exist. So replacing it with a new field called 'inner'.

aditya-bhawsingka avatar Oct 21 '20 04:10 aditya-bhawsingka

Coverage Status

Coverage remained the same at 90.416% when pulling c953d3467d97b0a0f9ce6041b1cd717b7f43b4ee on aditya-ignite:master into a4ff3f4d5be78071f015efe003e976d31d4eba10 on miLibris:master.

coveralls avatar Oct 21 '20 05:10 coveralls

Coverage Status

Coverage remained the same at 90.416% when pulling c953d3467d97b0a0f9ce6041b1cd717b7f43b4ee on aditya-ignite:master into a4ff3f4d5be78071f015efe003e976d31d4eba10 on miLibris:master.

coveralls avatar Oct 21 '20 05:10 coveralls

I have the same problem this change was introduced https://github.com/marshmallow-code/marshmallow/commit/bff0ba2560b2812eeebed5d564e855a98809e66a Or here https://github.com/marshmallow-code/marshmallow/blob/dev/CHANGELOG.rst#300rc8-2019-07-04

igieon avatar Feb 08 '21 18:02 igieon